Skip to content

refactor(file_system): deduplicate read methods and use Vec<u8> #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2025
Merged

refactor(file_system): deduplicate read methods and use Vec<u8> #816

merged 1 commit into from
Nov 6, 2025
+46 −79

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented Nov 6, 2025 •
edited
Loading

Summary

Refactors the FileSystem trait to eliminate code duplication and improve maintainability:

  • Added read() method returning Vec<u8> as the primary file reading method
  • Deduplicated read_to_string() to call read() + UTF-8 validation
  • Removed read_to_string_bypass_system_cache() method (simplified API)
  • Updated PackageJson::parse() to work with Vec<u8> instead of String

🤖 Generated with Claude Code

@graphite-app
Copy link

graphite-app bot commented Nov 6, 2025

How to use the Graphite Merge Queue

Add the label merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Nov 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.26%. Comparing base (aa90a41) to head (6b1c9ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   94.40%   94.26%   -0.14%     
==========================================
  Files          17       17              
  Lines        3074     3071       -3     
==========================================
- Hits         2902     2895       -7     
- Misses        172      176       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #816 will not alter performance

Comparing refactor/deduplicate-filesystem-read (6b1c9ed) with main (aa90a41)1

Summary

✅ 10 untouched
⏩ 5 skipped2

Footnotes

  1. No successful run was found on main (6b1c9ed) during the generation of this report, so aa90a41 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Boshen Boshen marked this pull request as ready for review November 6, 2025 10:52
@Boshen Boshen added the merge label Nov 6, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Nov 6, 2025 •
edited by graphite-app bot
Loading

Merge activity

@Boshen
refactor(file_system): deduplicate read methods and use Vec<u8> (#816)
6b1c9ed 
## Summary

Refactors the FileSystem trait to eliminate code duplication and improve maintainability:

- Added `read()` method returning `Vec<u8>` as the primary file reading method
- Deduplicated `read_to_string()` to call `read()` + UTF-8 validation
- Removed `read_to_string_bypass_system_cache()` method (simplified API)
- Updated `PackageJson::parse()` to work with `Vec<u8>` instead of `String`

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@graphite-app graphite-app bot force-pushed the refactor/deduplicate-filesystem-read branch from e7fea04 to 6b1c9ed Compare November 6, 2025 10:54
@graphite-app graphite-app bot merged commit 6b1c9ed into main Nov 6, 2025
17 checks passed
@graphite-app graphite-app bot deleted the refactor/deduplicate-filesystem-read branch November 6, 2025 10:57
@Boshen Boshen mentioned this pull request Nov 6, 2025
Merged
@graphite-app graphite-app bot removed the merge label Nov 6, 2025
@Boshen Boshen mentioned this pull request Nov 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen